dockerfile: add testReproSourceDateEpoch#3456
Conversation
AkihiroSuda
force-pushed
the
testSourceDateEpochRepro
branch
3 times, most recently
from
cb3df30 to
9eccafa
Compare
AkihiroSuda
force-pushed
the
testSourceDateEpochRepro
branch
from
9eccafa to
9c5512a
Compare
AkihiroSuda
changed the title
AkihiroSuda
force-pushed
the
testSourceDateEpochRepro
branch
3 times, most recently
from
41dc466 to
0c0c7a7
Compare
AkihiroSuda
force-pushed
the
testSourceDateEpochRepro
branch
from
0c0c7a7 to
9803c9f
Compare
|
@tonistiigi Can we merge this? |
| t.Logf("SOURCE_DATE_EPOCH=%d", tm.Unix()) | ||
|
|
||
| dockerfile := []byte(`# The base image cannot be busybox, due to https://github.com/moby/buildkit/issues/3455 | ||
| FROM --platform=linux/amd64 debian:bullseye-20221219-slim@sha256:171530d298096f0697da36b3324182e872db77c66452b85783ea893680cc1b62 |
There was a problem hiding this comment.
alpine doesn't work either? If possible would like to avoid another non-mirrored image.
There was a problem hiding this comment.
Alpine's /bin/find lacks -newermt, -writable, etc.
There was a problem hiding this comment.
if we can't find a better solution, we might still need to add it to mirrors. Otherwise I think even different workers and frontend types in build matrix will each do their own pull.
There was a problem hiding this comment.
Alpine's /bin/find lacks -newermt, -writable, etc.
apk add findutils ?
There was a problem hiding this comment.
Alpine's /bin/find lacks -newermt, -writable, etc.
apk add findutils?
That will result in an unreproducible build, and pinning the apk version is hard
There was a problem hiding this comment.
That will result in an unreproducible build, and pinning the apk version is hard
Correct. https://github.com/tonistiigi/buildkit-alpine
Does integration.WithMirroredImages in L227 suffice?
But that is not with a digest? Also pin it directly to amd64-only digest if the test is amd64 specific.
There was a problem hiding this comment.
Updated to amd64-only digest
There was a problem hiding this comment.
Doesn't pass in arm anymore 😢
run.go:158:
Error Trace: /src/frontend/dockerfile/run.go:158
/src/frontend/dockerfile/dockerfile_test.go:228
Error: Received unexpected error:
docker.io/arm64v8/debian:bullseye-20230109-slim@sha256:1acb06a0c31fb467eb8327ad361f1091ab265e0bf26d452dea45dcb0c0ea5e75: not found
Test: TestIntegration
There was a problem hiding this comment.
If you put the pins in https://github.com/moby/buildkit/blob/master/util/testutil/integration/pins.go (and use amd64 digest for arm, with a comment) then I think it should work.
AkihiroSuda
force-pushed
the
testSourceDateEpochRepro
branch
2 times, most recently
from
ad671f1 to
4524803
Compare
AkihiroSuda
force-pushed
the
testSourceDateEpochRepro
branch
from
4524803 to
1f76bc6
Compare
|
@tonistiigi PTAL 🙏 |
|
@AkihiroSuda I still had an issue on arm64 with the latest version but haven't had a chance to debug what the actual problem was yet. |
Shall we skip the test on non-amd64? |
Tests bit-for-bit reproducibility of OCI tar Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
testSourceDateEpochRepro
branch
from
1f76bc6 to
5786a98
Compare
|
Updated to skip the test on non-amd64 |
3 participants
Tests bit-for-bit reproducibility of OCI tar