fixes for history API#3530
Merged
tonistiigi merged 6 commits intomoby:masterfrom Jan 25, 2023
Merged
Conversation
Member
tonistiigi
commented
Jan 25, 2023
tonistiigi
commented
- logs and traces were not saved if a build was canceled or finished with an error
- exporter key was added in API, but correct value was never passed
- cache stats was added in add cache stats to the build history API #3440, but because the field for completed step count was not added the values were useless for canceled or errored builds
- there was no way to control the ref of the build other than running the monitor command. When two builds appeared at same time it was not possible to pair a build with a history record. @felixdesouza
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Otherwise the cache steps count values are useless for canceled and errored builds. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Member
Author
|
If needed, I'll remove the last commit from the |
Status and ListenHistory API return events with one-sided timestamp for events that have not been completed yet. Because client and server may not have exactly the same time the client can't really be sure what these values mean without knowing the current server time as well. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
crazy-max
reviewed
Jan 25, 2023
| bool pinned = 14; | ||
| int32 numCachedSteps = 15; | ||
| int32 numTotalSteps = 16; | ||
| int32 numCompletedSteps = 17; |
Member
There was a problem hiding this comment.
I guess completed steps also include DONE steps or is it unrelated?
crazy-max
approved these changes
Jan 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.