hack: do not cache some stages on release#3543
Merged
Merged
Conversation
thaJeztah
reviewed
Jan 27, 2023
crazy-max
changed the title
thaJeztah
reviewed
Jan 31, 2023
crazy-max
force-pushed
the
ci-nocache
branch
6 times, most recently
from
33d29bf to
54aaab9
Compare
jedevc
reviewed
Feb 1, 2023
jedevc
approved these changes
Feb 1, 2023
crazy-max
force-pushed
the
ci-nocache
branch
2 times, most recently
from
b00fb23 to
1985212
Compare
tonistiigi
reviewed
Feb 1, 2023
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
I'm not sure we need to disable cache for releases completely. The cache is already scoped. Having these separate codepaths makes it possible that the CI works fine, we tag a release and that release does not build at all.
crazy-max
changed the title
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
tonistiigi
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3542
Disables cache on release for some stages so packages are always installed and up to date.