Skip to content

do not mount secrets that are optional and missing from solve opts#3561

Merged
tonistiigi merged 1 commit into
moby:masterfrom
coryb:issue-3521
Feb 1, 2023
Merged

do not mount secrets that are optional and missing from solve opts#3561
tonistiigi merged 1 commit into
moby:masterfrom
coryb:issue-3521

Conversation

@coryb
Copy link
Copy Markdown
Collaborator

@coryb coryb commented Jan 31, 2023

fixes #3521

Copy link
Copy Markdown
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL linter error

Signed-off-by: coryb <cbennett@netflix.com>
@coryb
Copy link
Copy Markdown
Collaborator Author

coryb commented Feb 1, 2023

Fixed lint error, I think this is good to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Null optional secret still creates mount

3 participants