Skip to content

hack: do not set attest flags when exporting to docker#3597

Merged
crazy-max merged 1 commit into
moby:masterfrom
crazy-max:fix-hack-images
Feb 8, 2023
Merged

hack: do not set attest flags when exporting to docker#3597
crazy-max merged 1 commit into
moby:masterfrom
crazy-max:fix-hack-images

Conversation

@crazy-max
Copy link
Copy Markdown
Member

Attestation flags should not be set when loading image to docker otherwise:

$ ./hack/images local moby/buildkit
+ BUILDX_NO_DEFAULT_LOAD=true
+ BUILDX_BUILDER=
+ docker buildx build --tag=moby/buildkit:local --output=type=docker,buildinfo-attrs=true --attest=type=sbom --attest=type=provenance,mode=max .
ERROR: docker exporter does not currently support exporting manifest lists

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max added the area/hack building buildkit itself label Feb 8, 2023
@crazy-max crazy-max requested a review from jedevc February 8, 2023 12:03
@crazy-max crazy-max merged commit 0ccfe62 into moby:master Feb 8, 2023
@crazy-max crazy-max deleted the fix-hack-images branch February 8, 2023 12:35
@tonistiigi
Copy link
Copy Markdown
Member

Why do we need to pick this one? Looks like only used in dev?

@crazy-max
Copy link
Copy Markdown
Member Author

I tried to build a local buildkit image from 0.11 branch and it failed, hence the backport as it's a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/hack building buildkit itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants