Skip to content

git: override the locale to ensure consistent output#3598

Merged
tonistiigi merged 1 commit intomoby:masterfrom
crazy-max:git-locale
Feb 11, 2023
Merged

git: override the locale to ensure consistent output#3598
tonistiigi merged 1 commit intomoby:masterfrom
crazy-max:git-locale

Conversation

@crazy-max
Copy link
Copy Markdown
Member

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread source/git/gitsource.go
// "GIT_TRACE=1",
"GIT_CONFIG_NOSYSTEM=1", // Disable reading from system gitconfig.
"HOME=/dev/null", // Disable reading from user gitconfig.
"LC_ALL=C", // Ensure consistent output.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore; not sure if it's redundant, and already clear from the LC_ALL (which most people would understand does).

Suggested change
"LC_ALL=C", // Ensure consistent output.
"LC_ALL=C", // Ensure consistent, non-localized output.

@tonistiigi tonistiigi merged commit ad15d56 into moby:master Feb 11, 2023
@crazy-max crazy-max deleted the git-locale branch July 17, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants