Skip to content

integration: missing feature compat checks#3715

Merged
tonistiigi merged 3 commits intomoby:masterfrom
crazy-max:missing-cache-features
Mar 15, 2023
Merged

integration: missing feature compat checks#3715
tonistiigi merged 3 commits intomoby:masterfrom
crazy-max:missing-cache-features

Conversation

@crazy-max
Copy link
Copy Markdown
Member

@crazy-max crazy-max commented Mar 14, 2023

follow-up #3713 (comment)

@crazy-max crazy-max requested a review from tonistiigi March 14, 2023 15:14
@crazy-max crazy-max mentioned this pull request Mar 14, 2023
Merged
tonistiigi
tonistiigi reviewed Mar 14, 2023
View reviewed changes
Comment thread client/client_test.go Outdated
tonistiigi
tonistiigi reviewed Mar 14, 2023
View reviewed changes
Comment thread client/client_test.go
tonistiigi
tonistiigi reviewed Mar 14, 2023
View reviewed changes
Comment thread client/client_test.go Outdated
@crazy-max crazy-max force-pushed the missing-cache-features branch from f25ba2b to c9f2650 Compare March 14, 2023 17:01
@crazy-max
integration: missing feature compat check for cache
7f6cae2 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the missing-cache-features branch from c9f2650 to da959fd Compare March 14, 2023 18:28
tonistiigi
tonistiigi reviewed Mar 14, 2023
View reviewed changes
Comment thread client/client_test.go
@crazy-max
integration: split feature compat check for subtests
365598b 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@tonistiigi
Copy link
Copy Markdown
Member

tonistiigi commented Mar 15, 2023

Based on moby/moby#45153 (comment)

=== CONT  TestClientGatewayIntegration/TestClientGatewayNilResult/worker=dockerd
    build_test.go:2010: 
        	Error Trace:	/src/client/build_test.go:2010
        	            				/src/client/client.go:214
        	            				/src/client/build.go:59
        	            				/src/client/solve.go:283
        	            				/src/client/errgroup.go:75
        	            				/src/client/asm_amd64.s:1594
        	Error:      	Received unexpected error:
        	            	requested experimental feature diffop  has been disabled on the build server: only enabled with containerd image store backend
    ```

Also needs a mergeop feature check.

@crazy-max crazy-max force-pushed the missing-cache-features branch from da959fd to 365598b Compare March 15, 2023 09:53
@crazy-max
integration: missing mergeDiff compat check
f5aa841 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max changed the title integration: missing feature compat check for cache integration: missing feature compat checks Mar 15, 2023
@crazy-max
Copy link
Copy Markdown
Member Author

crazy-max commented Mar 15, 2023

Yes indeed: https://github.com/moby/moby/actions/runs/4425013900/jobs/7759638671#step:10:1874

@tonistiigi tonistiigi merged commit 3318657 into moby:master Mar 15, 2023
@crazy-max crazy-max deleted the missing-cache-features branch March 15, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees

No one assigned

Labels

area/testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crazy-max @tonistiigi