Register builds before recording build history#3726
Merged
Conversation
tonistiigi
reviewed
Mar 17, 2023
| } | ||
|
|
||
| if !internal { | ||
| rec, err1 := s.recordBuildHistory(ctx, id, req, exp, j) |
Member
There was a problem hiding this comment.
Looks like there is a typo (refactor bug) with this err1/err switch.
Collaborator
Author
There was a problem hiding this comment.
Thanks for noticing this. Looks like this was present before this PR. I've gone ahead and fixed the check on the next line (which I think is what's intended...).
Recording build history calls into LeaseManager, which can block for
several seconds. This can trigger a 3 second timeout in GatewayForwarder
while it waits for a build ID to be registered. Longer-term, we should
figure out the performance issues in the containerd metadata DB, but
this addresses the immediate problems of timeouts that manifest in these
error messages:
forwarding Ping: no such job 93oss3bmbagcpq8yokla3921z
Signed-off-by: Aaron Lehmann <alehmann@netflix.com>
aaronlehmann
force-pushed
the
register-build-earlier
branch
from
e73f671 to
396b276
Compare
tonistiigi
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording build history calls into
LeaseManager, which can block for several seconds. This can trigger a 3 second timeout inGatewayForwarderwhile it waits for a build ID to be registered. Longer-term, we should figure out the performance issues in the containerd metadata DB, but this addresses the immediate problems of timeouts that manifest in these error messages: