Make ClientOpts type safe#3761
Merged
jedevc merged 1 commit intomoby:masterfrom Mar 30, 2023
Merged
Conversation
This provides some compile-time safety around options passed when creating a buildkit client. Before this change since a ClientOpt is an empty interface anything and everything could be passed in. This is a breaking change since before consumers could pass in a raw grpc.DialOption, this now needs to be wrapped with `client.WithGRPCDialOption(grpcOpt)` Consumers could also pass in something tat was not a client opt at all and it was completely ignored. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
jedevc
approved these changes
Mar 29, 2023
tonistiigi
approved these changes
Mar 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides some compile-time safety around options passed when creating a buildkit client.
Before this change since a ClientOpt is an empty interface anything and everything could be passed in.
This is a breaking change since before consumers could pass in a raw grpc.DialOption, this now needs to be wrapped with
client.WithGRPCDialOption(grpcOpt)Consumers could also pass in something tat was not a client opt at all and it was completely ignored.