Add checks to avoid provenance and sbom post processing if not results were created #3805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
ref-may-be-empty
branch
from
d4090c6 to
7ca2cd9
Compare
tonistiigi
approved these changes
Apr 18, 2023
Member
|
this was cherry-picked in #3810 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⬆️ Follow-up to #3462.
This fixes the panic that we can trigger in docker/buildx#1640 (comment).
This scenario would happen if we returned a result containing no refs, but the solve opt specified we should have some platforms, we'd still attempt to access them, and panic.
This is probably a candidate for cherry-picking.
cc @ktock