fixes for history events#3827
Merged
Merged
Conversation
tonistiigi
force-pushed
the
history-fixes
branch
from
80519ac to
c089aa7
Compare
AkihiroSuda
reviewed
Apr 30, 2023
AkihiroSuda
approved these changes
Apr 30, 2023
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
This was defined in proto but looks like it was never actually implemented. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Previously this caused event for active builds to be resent to all client who are monitoring when new client makes a request. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure if a request is marked deleted (but not deleted yet because it has active reference), it doesn't show up in Listen responses anymore.
While debugging this, I also noticed 2 other small issues. Added in separate commits.
cc @aaronlehmann