vendor: github.com/docker/docker, github.com/docker/cli v24.0.0#3846
Merged
jedevc merged 5 commits intomoby:masterfrom May 22, 2023
Merged
vendor: github.com/docker/docker, github.com/docker/cli v24.0.0#3846jedevc merged 5 commits intomoby:masterfrom
jedevc merged 5 commits intomoby:masterfrom
Conversation
thaJeztah
force-pushed
the
engine_24.0.0-rc.2
branch
from
96935d6 to
92b1262
Compare
Member
|
Needs rebase |
thaJeztah
force-pushed
the
engine_24.0.0-rc.2
branch
2 times, most recently
from
be3d06b to
8fbbd65
Compare
thaJeztah
changed the title
Member
Author
|
rebased, and updated to rc.3 |
|
Hello, And I am a little curious why Buildkit did not migrate to full go modules and discard the vendor folder, it's somewhat painful to update vendor packages and we can hardly detect if the vendor code is malicious (nothing to do with this PR, just for curiosity :-)) |
Member
Author
|
The vendor directory both allows for faster builds (and in offline situations), as well as modules going AWOL (which happened a couple of times, and you'd only find out after Google's module proxy cache expires). In general, it also allows easier review changes introduced in dependencies (admitted, for dependencies like AWS sdk, it's near impossible to review. |
thaJeztah
force-pushed
the
engine_24.0.0-rc.2
branch
from
8fbbd65 to
2e8b8c3
Compare
thaJeztah
changed the title
thaJeztah
force-pushed
the
engine_24.0.0-rc.2
branch
from
2e8b8c3 to
faf77b7
Compare
thaJeztah
changed the title
Member
Author
|
Updated to v24.0.0 |
tonistiigi
approved these changes
May 16, 2023
AkihiroSuda
approved these changes
May 16, 2023
crazy-max
reviewed
May 16, 2023
| github.com/opencontainers/image-spec v1.1.0-rc3 | ||
| github.com/opencontainers/runc v1.1.6 | ||
| github.com/opencontainers/runtime-spec v1.1.0-rc.1 | ||
| github.com/opencontainers/runc v1.1.7 |
Member
There was a problem hiding this comment.
Might want follow-up to bump runc in Dockerfile
crazy-max
approved these changes
May 16, 2023
full diff: klauspost/compress@v1.16.0...v1.16.3 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: opencontainers/runtime-spec@v1.1.0-rc.1...v1.1.0-rc.2 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
no changes in vendored files full diff: opencontainers/runc@v1.1.6...v1.1.7 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: https://github.com/docker/docker/compare/v23.0.5..v24.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: https://github.com/docker/cli/compare/v23.0.5..v24.0.0 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
engine_24.0.0-rc.2
branch
from
faf77b7 to
282d334
Compare
Member
Author
|
Rebased to get a fresh run of CI |
jedevc
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendor: github.com/klauspost/compress v1.16.3
full diff: klauspost/compress@v1.16.0...v1.16.3
vendor: github.com/opencontainers/runtime-spec v1.1.0-rc.2
full diff: opencontainers/runtime-spec@v1.1.0-rc.1...v1.1.0-rc.2
vendor: github.com/opencontainers/runc v1.1.7
no changes in vendored files
full diff: opencontainers/runc@v1.1.6...v1.1.7
vendor: github.com/docker/docker v24.0.0
full diff: https://github.com/docker/docker/compare/v23.0.5..v24.0.0
vendor: vendor: github.com/docker/ci v24.0.0
full diff: https://github.com/docker/cli/compare/v23.0.5..v24.0.0