move flightcontrol to use generics#3949
Merged
tonistiigi merged 1 commit intomoby:masterfrom Jun 29, 2023
Merged
Conversation
Member
Author
|
This exposed some "missing provenance" errors. I don't want to change that code again before #3945 is merged. |
jedevc
reviewed
Jun 21, 2023
Comment on lines
+180
to
+182
| if rp.provenance == nil { | ||
| return nil | ||
| } |
Member
There was a problem hiding this comment.
Think it might be related to the change on line 280?
Member
|
Once the provenance errors are sorted, this LGTM 🎉 |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
flightcontrol-generics
branch
from
e46296c to
8ffc03b
Compare
Member
Author
|
Green after other PRs merged as expected. |
jedevc
reviewed
Jun 29, 2023
| @@ -806,7 +808,7 @@ func (s *sharedOp) CacheMap(ctx context.Context, index int) (resp *cacheMapResp, | |||
| return nil, err | |||
| } | |||
| flightControlKey := fmt.Sprintf("cachemap-%d", index) | |||
Member
There was a problem hiding this comment.
non-blocking: we can remove this flightControlKey and just use index now, since we split up the flight control instances.
jedevc
approved these changes
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be much safer than the
interface{}casts.