containerimage: keep layer labels for exported images#3972
Merged
tonistiigi merged 1 commit intomoby:masterfrom Jun 29, 2023
Merged
containerimage: keep layer labels for exported images#3972tonistiigi merged 1 commit intomoby:masterfrom
tonistiigi merged 1 commit intomoby:masterfrom
Conversation
When moving blobs to history namespace also move the blobs the labels point to, but don't move actual image layers. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
jedevc
approved these changes
Jun 29, 2023
This was referenced Jul 13, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When moving blobs to history namespace also move the blobs the labels point to, but don't move actual image layers.
fixes #3893
@vvoland
This was removed in 2be7e54 because I didn't want history objects to keep layers from getting deleted. But I didn't think about the case where image store using the same blob might still need the layers. Now when we move the blobs to separate history namespace, we can leave the layers in labels because if there is no image, then the main manifest will be released.