Dedupe "containerd.io/uncompressed" constants and literals#4058
Merged
crazy-max merged 1 commit intomoby:masterfrom Jul 25, 2023
Merged
Dedupe "containerd.io/uncompressed" constants and literals#4058crazy-max merged 1 commit intomoby:masterfrom
crazy-max merged 1 commit intomoby:masterfrom
Conversation
Dedupe the several "containerd.io/uncompressed" constants and literals into `github.com/containerd/containerd/labels.LabelUncompressed` Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
crazy-max
approved these changes
Jul 24, 2023
thaJeztah
approved these changes
Jul 25, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
all these code-paths were already importing containerd, and the labels package doesn't appear to be bringing in problematic dependencies (only "errdefs" and "testify" in a test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dedupe the several "containerd.io/uncompressed" constants and literals into
github.com/containerd/containerd/labels.LabelUncompressed