Skip to content

chore: remove unused blobIDs for nydus compression#4067

Merged
jedevc merged 1 commit intomoby:masterfrom
jedevc:nydus-cleanup-blobids
Jul 27, 2023
Merged

chore: remove unused blobIDs for nydus compression#4067
jedevc merged 1 commit intomoby:masterfrom
jedevc:nydus-cleanup-blobids

Conversation

@jedevc
Copy link
Copy Markdown
Member

@jedevc jedevc commented Jul 26, 2023

#3814 updated nydus to not use blobIDs but didn't remove it's creation.

cc @changweige

@jedevc jedevc requested a review from crazy-max July 26, 2023 16:04
@jedevc
Copy link
Copy Markdown
Member Author

jedevc commented Jul 26, 2023

This should have been caught by a linter in CI - but we don't run the linter on the nydus build tag, I'll work on a follow-up.

Copy link
Copy Markdown

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm

Signed-off-by: Justin Chadwell <me@jedevc.com>
@jedevc jedevc force-pushed the nydus-cleanup-blobids branch from 61b9176 to d6bdf7b Compare July 27, 2023 08:40
@jedevc jedevc merged commit 01e6ba6 into moby:master Jul 27, 2023
@jedevc jedevc deleted the nydus-cleanup-blobids branch July 27, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants