FreeBSD CI Run logs retention#4089
Merged
jedevc merged 1 commit intomoby:masterfrom Aug 2, 2023
Merged
Conversation
akhramov
force-pushed
the
feature/freebsd-ci-run-logs-retention
branch
from
73b4cb3 to
ba01999
Compare
Merged
jedevc
reviewed
Aug 2, 2023
Comment on lines
+114
to
+120
| - name: Archive integration test artifacts | ||
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: freebsd-run-logs | ||
| path: run-logs | ||
| retention-days: 5 |
Member
There was a problem hiding this comment.
We should always run this step, I think this only runs if the previous job succeeds.
Also, if we could print out the logs similar to how we do for the other tests, see https://github.com/moby/buildkit/actions/runs/5737822387/job/15550263885?pr=4089#step:19:3.
Contributor
Author
There was a problem hiding this comment.
Thanks, fixed. I also changed the test image tag, for the old one was removed.
Member
There was a problem hiding this comment.
Instead of uploading to workflow artifacts we could have just print them if the test step failed.
Member
There was a problem hiding this comment.
Ah sorry @jedevc, I missed this upload-artifact step has been removed. Looks good then 👍
akhramov
force-pushed
the
feature/freebsd-ci-run-logs-retention
branch
9 times, most recently
from
c048e4b to
e863405
Compare
This is a follow-up to moby#2376 (comment). Currently, once the integration test has been run, there is no way to check the buildkitd / containerd logs. This change adds a step to print the logs Signed-off-by: Artem Khramov <akhramov@pm.me>
jedevc
approved these changes
Aug 2, 2023
Member
|
Thanks @akhramov, much appreciated ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FreeBSD CI Run logs retention
This is a follow-up to
#2376 (comment).
Currently, once the integration test has been run, there is no way to
check the buildkitd / containerd logs.
This change adds a step to print the logs