tests: refactor Tmpdir as a test helper#4093
Merged
jedevc merged 1 commit intomoby:masterfrom Aug 3, 2023
Merged
Conversation
Errors from Tmpdir are always passed as an argument to require.NoError, so we can instead move this error check to inside the helper, to avoid a few extra lines in tests that call it. Signed-off-by: Justin Chadwell <me@jedevc.com>
crazy-max
approved these changes
Aug 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Errors from
Tmpdirare always passed as an argument to require.NoError, so we can instead move this error check to inside the helper, to avoid a few extra lines in tests that call it.Related: docker/buildx@d03e93f