v0.11: backport llbsolver: fix policy rule ordering#4215
Merged
jedevc merged 1 commit intomoby:v0.11from Sep 8, 2023
Merged
Conversation
The older of rules in policy matters. Eg. in [DENY *, ALLOW ref] mixing the order would deny all sources so map can't be used to deduplicate the rules. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 22d8446) Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
changed the title
tonistiigi
approved these changes
Sep 7, 2023
cpuguy83
added a commit
to cpuguy83/docker
that referenced
this pull request
Sep 8, 2023
This brings in moby/buildkit#4215 which fixes a major issue with source policies in buildkit. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #4014 to v0.11 so we can pull this into moby v24.
--
The older of rules in policy matters. Eg. in [DENY *, ALLOW ref] mixing the order would deny all sources so map can't be used to deduplicate the rules.
(cherry picked from commit 22d8446)