integration: set otel socket path through buildkit config#4280
Merged
crazy-max merged 1 commit intomoby:masterfrom Sep 27, 2023
Merged
integration: set otel socket path through buildkit config#4280crazy-max merged 1 commit intomoby:masterfrom
crazy-max merged 1 commit intomoby:masterfrom
Conversation
tonistiigi
reviewed
Sep 26, 2023
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
testutil-buildkit-config
branch
from
df78442 to
5db24ae
Compare
tonistiigi
approved these changes
Sep 26, 2023
This was referenced Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up docker/buildx#2035 (comment)
related to #4101
Set otel socket path in integration tests using buildkit config instead of setting the
otel-socket-pathflag to avoid breaking change with older buildkit version.tested in docker/buildx#2060