Make output window configurable: BUILDKIT_TERMHEIGHT#4284
Conversation
|
I like the tty output, but I normally have tall windows and found myself annoyed by only having 6 lines of |
f772bfe to
98bc4eb
Compare
tonistiigi
left a comment
There was a problem hiding this comment.
Iiuc this is not the window or viewport height (that is detected automatically from tty), but how many log lines are visible for active steps in tty mode (if there is enough room). In that case, the more suitable name would be something like BUILDKIT_TTY_LOG_LINES or smth like that?
Theoretically, this could be somewhat automatically detected by counting the active lines and comparing them with the screen height. Eg. if the screen height is 40 lines, the whole tty output is 10 lines, and there is only one active step then indeed the logs for the active step should not be limited by 6 lines but could take 2-3 times more room. If more lines go active or the screen is resized then it should reduce the limit though. Atm. this logic is more simplified, every active step gets a maximum of 6 lines and if it doesn't fit anymore then the logs for some steps are not shown anymore. |
Sure, I'll change it. I based the env var on the variable already in the code, which is confusingly named. |
669a0e3 to
e7aa5c2
Compare
The output window was previously hard-coded to a height of 6; this patch makes it configurable at run-time by setting the BUILDKIT_TTY_LOG_LINES environment variable. Signed-off-by: Burt Holzman <burt@fnal.gov>
e7aa5c2 to
2677a22
Compare
The output window was previously hard-coded to a height of 6; this patch makes it configurable at run-time by setting the BUILDKIT_TERMHEIGHT environment variable.