vendor: update nydus-snapshotter to v0.13.1#4288
Merged
tonistiigi merged 1 commit intomoby:masterfrom Oct 31, 2023
Merged
Conversation
jedevc
commented
Sep 28, 2023
| github.com/containerd/go-cni v1.1.9 | ||
| github.com/containerd/go-runc v1.1.0 | ||
| github.com/containerd/nydus-snapshotter v0.8.2 | ||
| github.com/containerd/nydus-snapshotter v0.13.0 |
Member
Author
There was a problem hiding this comment.
Not sure if we also need to bump nydusd (as in #3814).
Contributor
There was a problem hiding this comment.
Thanks for the PR, it's okay to keep the current nydusd version in buildkit.
thaJeztah
requested changes
Sep 28, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
leaving a "request changes" so that we can discuss the changes in dependencies before we decide whether to merge as-is or if there's a way to make the changes more minimal.
This was referenced Sep 28, 2023
jedevc
force-pushed
the
vendor-nydus-snapshotter
branch
from
ade49e3 to
084f69e
Compare
jedevc
changed the title
jedevc
force-pushed
the
vendor-nydus-snapshotter
branch
from
084f69e to
9507e2a
Compare
Member
Author
|
Since this bumps gRPC, this is dependent on #4341. |
thaJeztah
reviewed
Oct 26, 2023
Signed-off-by: Justin Chadwell <me@jedevc.com>
jedevc
force-pushed
the
vendor-nydus-snapshotter
branch
from
9507e2a to
416f7cb
Compare
thaJeztah
approved these changes
Oct 27, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
removing my "request for changes"
LGTM (if CI is happy)
tonistiigi
approved these changes
Oct 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This unblocks #4261 (see containerd/nydus-snapshotter#537).
Main external dependencies updated:
Just glancing through the vendor diff there's nothing specifically that stands out to me as particularly troublesome.
cc @changweige @imeoer