dockerfile: use glibc to build riscv64#4332
Closed
crazy-max wants to merge 2 commits intomoby:masterfrom
Closed
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
build-riscv64-libc
branch
from
593eedb to
9c2aa0d
Compare
crazy-max
changed the title
Member
|
As discussed offline, if we can't figure this out we should just temporarily remove riscv instead of trying to change base image for patch release. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to mitigate #4316 so we can release 0.12.3.
With this change binaries (runc and buildkitd) will be built with glibc on riscv64. As we are building static binaries this is fine to keep alpine as base image. Adds smoke tests in our pipeline as well.