Send hcsshim's options struct when running with hcsshim#4364
Merged
jedevc merged 1 commit intomoby:masterfrom Oct 22, 2023
Merged
Send hcsshim's options struct when running with hcsshim#4364jedevc merged 1 commit intomoby:masterfrom
jedevc merged 1 commit intomoby:masterfrom
Conversation
containerd-shim-runhcs-v1 does not know how to parse the default containerd runtimeoptions.v1.Options structure, and panics at startup. Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
This was referenced Oct 22, 2023
gabriel-samfira
approved these changes
Oct 22, 2023
Collaborator
gabriel-samfira
left a comment
gabriel-samfira
left a comment
There was a problem hiding this comment.
LGTM. Thanks @TBBle !
gabriel-samfira
approved these changes
Oct 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
containerd-shim-runhcs-v1does not know how to parse the default containerdruntimeoptions.v1.Optionsstructure, and fails at start-up.Ref: microsoft/hcsshim#1941
The same logic is used in containerd/cri, and I'm not aware of any other better source for that constant string at the moment than just locally defining it. I suggested in microsoft/hcsshim#1941 that it be exported from the same package as the
containerd.runhcs.v1.Optionsstructure.