containerd: support custom shim path #4404
Merged
tonistiigi merged 2 commits intomoby:masterfrom Nov 15, 2023
Merged
Conversation
Signed-off-by: Justin Chadwell <me@jedevc.com>
Like CRI, we should support custom shim paths. We can just add this as a new config field "path" under the runtime object. While "name" can be either the name of a custom shim (from which a path is derived), or a path itself, if configured as a path, no options can be provided - this is because to derive the type for the options struct, we need the name to be a member of a well-known set (currently runc and hcs). With this patch, it's now possible to configure a runtime with a custom shim at a non-default path, and include it's options (which was previously not possible to do in buildkit). Signed-off-by: Justin Chadwell <me@jedevc.com>
tonistiigi
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4279
Like CRI, we should support custom shim paths. We can just add this as a new config field
pathunder the runtime object.While
namecan be either the name of a custom shim (from which a path is derived), or a path itself, if configured as a path, no options can be provided - this is because to derive the type for the options struct, we need the name to be a member of a well-known set (currently runc and hcs).With this patch, it's now possible to configure a runtime with a custom shim at a non-default path, and include it's options (which was previously not possible to do in buildkit).