solver: remove unneccessary solver lock#4738
Merged
jedevc merged 2 commits intomoby:masterfrom Mar 6, 2024
Merged
Conversation
This lock has been moved into WalkProvenance. Co-Authored-By: Alex Couture-Beil <alex@mofo.ca> Signed-off-by: Justin Chadwell <me@jedevc.com>
We already have a function with this annotation, makes sense to also annotate these (this was helpful when trying to understand this separately from the original case). Signed-off-by: Justin Chadwell <me@jedevc.com>
alexcb
approved these changes
Mar 6, 2024
tonistiigi
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lock has been moved into
WalkProvenancein #3240 and #3938.Pointed out by @alexcb in the Buildkit community slack here.