[v0.13] v0.13.1 cherry-picks#4779
Merged
tonistiigi merged 4 commits intomoby:v0.13from Mar 18, 2024
Merged
Conversation
This method is needed by GHA cache backend to detect if Github deletes blobs from the cache because of storage caps. It got missing when Info() support was added. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 5a8856d)
URLs that look like `./path/to/file` and `../path/to/file` definitely aren't git URLs - so we should bail out early. This was causing a weird issue where if you copied `./.git` this would be detected as a valid url parsing with `host = "."` and `path = "/git"`. The fix for this is to make sure that for these explicit file-like paths, we *never* parse them as url-refs. Also some tests to make sure this doesn't break again! Signed-off-by: Justin Chadwell <me@jedevc.com> (cherry picked from commit 95ca25e)
The source path changed in v0.13 and there are reports that new path can cause error on starting a container. While this is investigated, check for missing path and make mounting optional like it was in v0.12. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 33b347a)
crazy-max
approved these changes
Mar 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solver: stub out sysSampler close #4775
git: ensure file-looking git refs aren't parsed as URLs #4776
oci: make mounting oci socket optional #4778