Skip to content

vendor: github.com/containerd/containerd v1.7.18#4956

Merged
tonistiigi merged 1 commit intomoby:masterfrom
thaJeztah:vendor_containerd_1.7.18
Jun 5, 2024
Merged

vendor: github.com/containerd/containerd v1.7.18#4956
tonistiigi merged 1 commit intomoby:masterfrom
thaJeztah:vendor_containerd_1.7.18

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented May 28, 2024

Update to containerd 1.7.18, which now migrated to the errdefs module. The existing errdefs package is now an alias for the module, and should no longer be used directly.

This patch:

  • updates the containerd dependency: containerd/containerd@v1.7.17...v1.7.18
  • replaces uses of the old package in favor of the new module
  • adds a linter check to prevent accidental re-introduction of the old package
  • adds a linter check to enforce using an alias, to prevent accidental use of the errdefs package in BuildKit or Moby.
  • adds a linter check to prevent using the "log" package, which was also migrated to a separate module.

There are still some uses of the old package in (indirect) dependencies, which should go away over time.

@thaJeztah thaJeztah self-assigned this May 28, 2024
@thaJeztah thaJeztah force-pushed the vendor_containerd_1.7.18 branch 3 times, most recently from 3ab93cc to b930942 Compare May 29, 2024 12:10
Update to containerd 1.7.18, which now migrated to the errdefs module. The
existing errdefs package is now an alias for the module, and should no longer
be used directly.

This patch:

- updates the containerd dependency: containerd/containerd@v1.7.17...v1.7.18
- replaces uses of the old package in favor of the new module
- adds a linter check to prevent accidental re-introduction of the old package
- adds a linter check to enforce using an alias, to prevent accidental use
  of the errdefs package in BuildKit or Moby.
- adds a linter check to prevent using the "log" package, which was also
  migrated to a separate module.

There are still some uses of the old package in (indirect) dependencies,
which should go away over time.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the vendor_containerd_1.7.18 branch from b930942 to 0f89a76 Compare June 5, 2024 06:59
@thaJeztah thaJeztah changed the title WIP: vendor: github.com/containerd/containerd v1.7.18 vendor: github.com/containerd/containerd v1.7.18 Jun 5, 2024
@thaJeztah thaJeztah marked this pull request as ready for review June 5, 2024 07:02
@thompson-shaun thompson-shaun added this to the v0.14.0 milestone Jun 5, 2024
@tonistiigi tonistiigi merged commit 1128073 into moby:master Jun 5, 2024
@thaJeztah thaJeztah deleted the vendor_containerd_1.7.18 branch June 5, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants