Remove pre-Go 1.17 build tags

[slonopotamus]

I believe that BuildKit cannot be built with such an old Go and there's no reason to keep these legacy tags.

---

The only manual change is util/archutil/generate.go. All the rest is just a result of go fix ./...

[tonistiigi]

Is there a validation preventing this from coming back in future updates? What is the typical behavior in vscode etc. or how is it controlled there?

[slonopotamus]

Sorry, no idea, I don't use VSCode. I use GoLand. It highlights these tags as obsolete and suggests removing them.

[thaJeztah]

go fix can remove these automatically; so far, I haven't found a linter for this, but you could add something similar as to what was done in runc;

• ci/gha: add go-fix job opencontainers/runc#4332

[slonopotamus]

Is there an actual problem with tags still being added? Or they are just legacy leftovers? If you really want, I can add a job similar to opencontainers/runc#4332

[crazy-max]

I can add a job similar to opencontainers/runc#4332

If we want smth like this it would not be a new ci job but embedded in our sandbox like any other validation tool we are using.

[thaJeztah]

I personally don't think it's a huge problem. I'm not a VSCode user, and don't know if it's adding them, but I know that my GoLand flags their presence as a warning depending on the version of Go used;

[thaJeztah]

I should add that the go fix could still be interesting for other reasons, but I don't think it's necessarily needed for this PR.

I do recall that when I removed them in moby (using go fix) it left some behind; not sure what happened at the time, or if it was due to build-tags / platform; moby/moby#46316

[thaJeztah]

Looks like go fix left a couple behind here as well;

git grep '// +build' -- ':!vendor/'
examples/gobuild/main.go:// +build ignore
tools/tools.go:// +build tools
worker/runc/runc.go:// +build linux
worker/runc/runc_test.go:// +build linux

[slonopotamus]

I should add that the go fix could still be interesting for other reasons, but I don't think it's necessarily needed for this PR.

I'd prefer to leave this out of scope of current PR.

Looks like go fix left a couple behind here as well;

Fixed

[thaJeztah]

LGTM (non-binding)