remotecache: avoid ultra deep recursion for complex cache layouts#6168
Closed
BtbN wants to merge 1 commit into
Closed
remotecache: avoid ultra deep recursion for complex cache layouts#6168BtbN wants to merge 1 commit into
BtbN wants to merge 1 commit into
Conversation
Signed-off-by: BtbN <btbn@btbn.de>
BtbN
force-pushed
the
loop_detection_fix
branch
from
aaef19f to
9704b7e
Compare
Member
Collaborator
|
I'm going to close this since the code it modifies no longer exists. From looking at the code, I think the new code still needs to be modified to remove recursion from the implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6082 and #6008
I don't have a way to easily reproduce the cache loop detection issue, but I have run into it multiple times.
Looking at the logs and the code, this should hopefully greatly reduce the detph and width the recursion can reach here, hopefully speeding it up in the process.
I have not been able to verify if this actually solves the issue yet. But the change looks sensible to me either way.