gitutil: avoid global git config lookup on Windows#6639
Merged
crazy-max merged 1 commit intomoby:masterfrom Apr 2, 2026
Merged
gitutil: avoid global git config lookup on Windows#6639crazy-max merged 1 commit intomoby:masterfrom
crazy-max merged 1 commit intomoby:masterfrom
Conversation
tonistiigi
commented
Apr 1, 2026
| "HOME=/dev/null", // Disable reading from user gitconfig. | ||
| "LC_ALL=C", // Ensure consistent output. | ||
| } | ||
| if runtime.GOOS == "windows" { |
Member
Author
There was a problem hiding this comment.
It is possible that this works with just GIT_CONFIG_GLOBAL=os.DevNull but I have no way to verify.
Member
There was a problem hiding this comment.
I tested on a Windows host with Git for Windows (git 2.46.0.windows.1), and the fix direction looks right. HOME=/dev/null still breaks there, while HOME=NUL plus an explicit GIT_CONFIG_GLOBAL avoids the global config lookup failure.
And the temp file doesn't seem necessary. GIT_CONFIG_GLOBAL= + os.DevNull also appears to work on Windows in my local probes, so GIT_CONFIG_GLOBAL=os.DevNull may be enough and would avoid creating and cleaning up a temp file for every git invocation.
Member
There was a problem hiding this comment.
Also not directly related but I have this PR to support git host config: #6624
Member
Author
There was a problem hiding this comment.
Given that, I removed the whole windows specific condition and just set GIT_CONFIG_GLOBAL everywhere.
Avoid global conf lookup via HOME that fails on Windows. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
git-windows-conf-fix
branch
from
37338e6 to
e6e6026
Compare
rzlink
pushed a commit
to rzlink/buildkit
that referenced
this pull request
Apr 13, 2026
On Windows ARM64, git cannot use the NUL device as HOME or GIT_CONFIG_GLOBAL path, failing with "fatal: unable to access 'NUL': Invalid argument". This was introduced by e6e6026 (PR moby#6639) which changed HOME=/dev/null to HOME=os.DevNull. Add platform-specific helpers: on Unix, continue using /dev/null; on Windows, lazily create an empty temp directory for HOME and an empty temp file for GIT_CONFIG_GLOBAL. Signed-off-by: rzlink <nicklin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rzlink
pushed a commit
to rzlink/buildkit
that referenced
this pull request
Apr 13, 2026
On Windows ARM64, git cannot use the NUL device as HOME or GIT_CONFIG_GLOBAL path, failing with "fatal: unable to access 'NUL': Invalid argument". This was introduced by e6e6026 (PR moby#6639) which changed HOME=/dev/null to HOME=os.DevNull. Add platform-specific helpers: on Unix, continue using /dev/null; on Windows, lazily create an empty temp directory for HOME and an empty temp file for GIT_CONFIG_GLOBAL. Signed-off-by: rzlink <nicklin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rzlink
pushed a commit
to rzlink/buildkit
that referenced
this pull request
Apr 22, 2026
On Windows ARM64, git cannot use the NUL device as HOME or GIT_CONFIG_GLOBAL path, failing with "fatal: unable to access 'NUL': Invalid argument". This was introduced by e6e6026 (PR moby#6639) which changed HOME=/dev/null to HOME=os.DevNull. Add platform-specific helpers: on Unix, continue using /dev/null; on Windows, lazily create an empty temp directory for HOME and an empty temp file for GIT_CONFIG_GLOBAL. Signed-off-by: rzlink <nicklin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rzlink
pushed a commit
to rzlink/buildkit
that referenced
this pull request
Apr 23, 2026
On Windows ARM64, git cannot use the NUL device as HOME or GIT_CONFIG_GLOBAL path, failing with "fatal: unable to access 'NUL': Invalid argument". This was introduced by e6e6026 (PR moby#6639) which changed HOME=/dev/null to HOME=os.DevNull. Add platform-specific helpers: on Unix, continue using /dev/null; on Windows, lazily create an empty temp directory for HOME and an empty temp file for GIT_CONFIG_GLOBAL. Signed-off-by: rzlink <nicklin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rzlink
pushed a commit
to rzlink/buildkit
that referenced
this pull request
Apr 28, 2026
On Windows ARM64, git cannot use the NUL device as HOME or GIT_CONFIG_GLOBAL path, failing with "fatal: unable to access 'NUL': Invalid argument". This was introduced by e6e6026 (PR moby#6639) which changed HOME=/dev/null to HOME=os.DevNull. Add platform-specific helpers: on Unix, continue using /dev/null; on Windows, lazily create an empty temp directory for HOME and an empty temp file for GIT_CONFIG_GLOBAL. Signed-off-by: rzlink <nicklin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rzlink
added a commit
to rzlink/buildkit
that referenced
this pull request
May 1, 2026
On Windows ARM64, git cannot use the NUL device as HOME or GIT_CONFIG_GLOBAL path, failing with "fatal: unable to access 'NUL': Invalid argument". This was introduced by e6e6026 (PR moby#6639) which changed HOME=/dev/null to HOME=os.DevNull. Add platform-specific helpers: on Unix, continue using /dev/null; on Windows, lazily create an empty temp directory for HOME and an empty temp file for GIT_CONFIG_GLOBAL. Signed-off-by: Dawei Wei <wei.dawei.cn@gmail.com>
rzlink
pushed a commit
to rzlink/buildkit
that referenced
this pull request
May 4, 2026
On Windows ARM64, git cannot use the NUL device as HOME or GIT_CONFIG_GLOBAL path, failing with "fatal: unable to access 'NUL': Invalid argument". This was introduced by e6e6026 (PR moby#6639) which changed HOME=/dev/null to HOME=os.DevNull. Add platform-specific helpers: on Unix, continue using /dev/null; on Windows, lazily create an empty temp directory for HOME and an empty temp file for GIT_CONFIG_GLOBAL. Signed-off-by: rzlink <nicklin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rzlink
pushed a commit
to rzlink/buildkit
that referenced
this pull request
May 5, 2026
On Windows ARM64, git cannot use the NUL device as HOME or GIT_CONFIG_GLOBAL path, failing with "fatal: unable to access 'NUL': Invalid argument". This was introduced by e6e6026 (PR moby#6639) which changed HOME=/dev/null to HOME=os.DevNull. Add platform-specific helpers: on Unix, continue using /dev/null; on Windows, lazily create an empty temp directory for HOME and an empty temp file for GIT_CONFIG_GLOBAL. Signed-off-by: rzlink <nicklin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rzlink
pushed a commit
to rzlink/buildkit
that referenced
this pull request
May 6, 2026
On Windows ARM64, git cannot use the NUL device as HOME or GIT_CONFIG_GLOBAL path, failing with "fatal: unable to access 'NUL': Invalid argument". This was introduced by e6e6026 (PR moby#6639) which changed HOME=/dev/null to HOME=os.DevNull. Add platform-specific helpers: on Unix, continue using /dev/null; on Windows, lazily create an empty temp directory for HOME and an empty temp file for GIT_CONFIG_GLOBAL. Signed-off-by: rzlink <nicklin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rzlink
pushed a commit
to rzlink/buildkit
that referenced
this pull request
May 7, 2026
On Windows ARM64, git cannot use the NUL device as HOME or GIT_CONFIG_GLOBAL path, failing with "fatal: unable to access 'NUL': Invalid argument". This was introduced by e6e6026 (PR moby#6639) which changed HOME=/dev/null to HOME=os.DevNull. Add platform-specific helpers: on Unix, continue using /dev/null; on Windows, lazily create an empty temp directory for HOME and an empty temp file for GIT_CONFIG_GLOBAL. Signed-off-by: rzlink <nicklin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
rzlink
pushed a commit
to rzlink/buildkit
that referenced
this pull request
May 8, 2026
On Windows ARM64, git cannot use the NUL device as HOME or GIT_CONFIG_GLOBAL path, failing with "fatal: unable to access 'NUL': Invalid argument". This was introduced by e6e6026 (PR moby#6639) which changed HOME=/dev/null to HOME=os.DevNull. Add platform-specific helpers: on Unix, continue using /dev/null; on Windows, lazily create an empty temp directory for HOME and an empty temp file for GIT_CONFIG_GLOBAL. Signed-off-by: rzlink <nicklin@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #6567
Use a Windows-specific empty temp file for GIT_CONFIG_GLOBAL while keeping the existing null-device HOME behavior on non-Windows. Preserve the current SSH command handling and add focused gitutil coverage for the config-path behavior.