rootless: use Giuseppe's newuidmap/newgidmap#686
Conversation
| # We lock the root account by `passwd -l root`, so as to disable su completely. | ||
|
|
||
| # tonistiigi/buildkit:rootless-base is a pre-built multi-arch version of rootless-base-internal https://github.com/moby/buildkit/pull/666#pullrequestreview-161872350 | ||
| FROM tonistiigi/buildkit:rootless-base@sha256:6d9c50e2d006c2a8745e9d7f2bc075e4469191eccada41936ec0c6070361d45a AS rootless-base-external |
There was a problem hiding this comment.
I set status/do-not-merge label because tonistiigi/buildkit:rootless-base needs to be updated
@tonistiigi please update the image if LGTY
There was a problem hiding this comment.
tonistiigi/buildkit:rootless-base@sha256:d0ad2d97de253eca727679e22cc6a5982b6aa79d048ef6c79e4938204a6dc803
There was a problem hiding this comment.
@AkihiroSuda Do you want me to recreate this after the last modifications?
There was a problem hiding this comment.
tonistiigi/buildkit:rootless-base@sha256:51a8017db80e9757fc05071996947abb5d3e91508c3d641b01cfcaeff77e676e
AkihiroSuda
force-pushed
the
use-giuseppe-newuidmap
branch
from
8baff95 to
1d10c56
Compare
|
I'd like to release v0.3.1 when this PR gets merged |
|
|
||
| FROM alpine AS rootless-base-internal | ||
| RUN apk add --no-cache git shadow shadow-uidmap \ | ||
| RUN apk add --no-cache git |
There was a problem hiding this comment.
This doesn't build for me. Needs apk add --no-cache git shadow for the useradd binary.
There was a problem hiding this comment.
fixed to use busybox adduser
AkihiroSuda
force-pushed
the
use-giuseppe-newuidmap
branch
2 times, most recently
from
ca8f151 to
ba5636a
Compare
Apply shadow-maint/shadow#132 so that newuidmap/newgidmap doesn't require CAP_SYS_ADMIN Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
|
thanks, updated |
AkihiroSuda
force-pushed
the
use-giuseppe-newuidmap
branch
from
ba5636a to
ed64652
Compare
|
release seems failing. PTAL? https://travis-ci.org/moby/buildkit/builds/442025898?utm_source=github_status&utm_medium=notification |
|
|
||
| # tonistiigi/buildkit:rootless-base is a pre-built multi-arch version of rootless-base-internal https://github.com/moby/buildkit/pull/666#pullrequestreview-161872350 | ||
| FROM tonistiigi/buildkit:rootless-base@sha256:6d9c50e2d006c2a8745e9d7f2bc075e4469191eccada41936ec0c6070361d45a AS rootless-base-external | ||
| FROM tonistiigi/buildkit:rootless-base@sha256:51a8017db80e9757fc05071996947abb5d3e91508c3d641b01cfcaeff77e676e |
Fix grammar
2 participants
Apply shadow-maint/shadow#132 so that newuidmap/newgidmap
doesn't require CAP_SYS_ADMIN
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp
Close #671