Skip to content

[wip] Improve logs for Docker for Mac#195

Closed
akimd wants to merge 6 commits intomoby:masterfrom
akimd:simplify-logs-2
Closed

[wip] Improve logs for Docker for Mac#195
akimd wants to merge 6 commits intomoby:masterfrom
akimd:simplify-logs-2

Conversation

@akimd
Copy link
Contributor

@akimd akimd commented Mar 28, 2018

No description provided.

akimd added 3 commits March 28, 2018 14:23
@akimd
Go: move to go dep
6bce3a0 
Dep federates all the efforts from the go community.

Signed-off-by: Akim Demaille <akim.demaille@docker.com>
@akimd
Go: add "legal" files to vendoring
123fcfd 
`dep` left these files.  The documentation reports "Out of an
abundance of caution, dep non-optionally preserves files that may have
legal significance."

Signed-off-by: Akim Demaille <akim.demaille@docker.com>
@akimd
Go: update golang.org/x/sys/unix
fa91964 
The next commit introduces logrus, whose dependencies fail to compile
with the version of golang.org/x/sys/unix that was previously pinned.

Signed-off-by: Akim Demaille <akim.demaille@docker.com>
@ijc
Copy link
Collaborator

ijc commented Mar 28, 2018

Please stay with vndr. For the missing LICENSE files I think all that is needed is to rerun it with a newer version of vndr, it has been keeping those files for a very long time and works fine for other moby projects.

@akimd
Copy link
Contributor Author

akimd commented Mar 28, 2018

Hi @ijc. vndr is the past already. I'm not sure I understand why we should still be waiting to migrate. All the other Docker components made the move already.

@ijc
Copy link
Collaborator

ijc commented Mar 28, 2018

go dep is "the official experiment" and a "prototype" I see no reason to rush to it and to declare vndr as "the past" is pure hyperbole.

vndr is still the de facto vendoring tool used in the Moby project and in related projects (moby, docker/cli, buildkit, containerd, runc, linuxkit all continue to use vndr at the moment AFAICT).

Switching to go dep right now is premature, please drop those changes from this PR.

akimd added 3 commits March 28, 2018 15:57
@akimd
Go: expect logrus
56524e0 
Signed-off-by: Akim Demaille <akim.demaille@docker.com>
@akimd
Go: run dep ensure
c04346b 
To satisfy the new dependency on logrus.

Signed-off-by: Akim Demaille <akim.demaille@docker.com>
@akimd
Go: insinuate Apple's ASL logging system
17531dd 
Signed-off-by: Akim Demaille <akim.demaille@docker.com>
@akimd akimd force-pushed the simplify-logs-2 branch from 286fa16 to 17531dd Compare March 28, 2018 13:57
@justincormack
Copy link
Contributor

justincormack commented Mar 28, 2018

go dep is no longer going to be the standard dependency tool it is now just another casualty on the road to somewhere...

ijc
ijc requested changes Mar 29, 2018
View reviewed changes
Copy link
Collaborator

@ijc ijc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thanks for the update @justincormack.

@akimd you can either git rebase the go dep patches out of this PR and force push or close and carry the other functional changes in a new PR, up to you.

@akimd
Copy link
Contributor Author

akimd commented Mar 29, 2018

@justincormack Yes, I'm eager to see what vgo becomes, how quickly it gets adopted, etc. Meanwhile, the traction that dep gets is quite clear however.

@ijc This is WIP. When I feel ready to submit something, I'll tidy and remove the tag. Meanwhile, this is a sandbox.

Cheers!

@ijc
Copy link
Collaborator

ijc commented Mar 29, 2018

This is WIP. When I feel ready to submit something, I'll tidy and remove the tag. Meanwhile, this is a sandbox.

OK. Please remove (don't just revert) the godep commits before removing the WIP tag.

@akimd
Copy link
Contributor Author

akimd commented Mar 30, 2018

Obsoleted by #196.

@akimd akimd closed this Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijc ijc ijc requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akimd @ijc @justincormack