Code cleanup using context #1835
Conversation
service_common.go
Outdated
| loadBalancer := lb | ||
| networkID := nid | ||
| cleanupFuncs = append(cleanupFuncs, func() { | ||
| ctx := context.WithValue(context.Background(), callerCtxKey, "rmServiceBinding") |
|
@abhinandanpb Thanks makes sense, I was hoping there was something more structured to achieve that result. |
abhi
force-pushed
the
cleanup
branch
4 times, most recently
from
4e2d241 to
ed21a4f
Compare
|
LGTM, @sanimej ? |
abhi
force-pushed
the
cleanup
branch
3 times, most recently
from
863bd1c to
67d664f
Compare
The debugs using the caller of method has been extremely useful in faster debugging and understanding of flow. This commit uses context to pass in the caller information instead of explicit method names. The ideal way would have been to use the runtime package Caller function to get the callers from the function stack instead of passing the method explicitly. However since the caller tree need not be symmetric it would make it ugly to retrieve the interested caller. Hencing moving the method name passing to context which would make it cleaner and more readable. Signed-off-by: Abhinandan Prativadi <abhi@docker.com>
|
@abhinandanpb Having the caller's name does help to follow the debugs quicker. But using context is probably is not the right thing to do here.. from the context package,
Using |
|
@sanimej: I agree completely. |
4 participants
The debugs using the caller of method has been extremely useful
in faster debugging and understanding of flow. This commit uses context
to pass in the caller information instead of explicit method names.
The ideal way would have been to use the runtime package Caller function
to get the callers from the function stack instead of passing the method
explicitly. However since the caller tree need not be symmetric it would
make it ugly to retrieve the interested caller. Hencing moving the method
name passing to context which would make it cleaner and more readable.
Signed-off-by: Abhinandan Prativadi abhi@docker.com