Skip to content

Conversation

@fcrisciani
Copy link

Reverts #1875

Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "revert-1875-restore_17.06" git@github.com:docker/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
@fcrisciani fcrisciani force-pushed the revert-1875-restore_17.06 branch from de9ea5f to 770e5ce Compare August 2, 2017 00:10
@mavenugo
Copy link
Contributor

mavenugo commented Aug 2, 2017

LGTM.

We will reintroduce this patch once we figure out why this breaks Integration-cli tests.

@mavenugo mavenugo merged commit f0b9939 into bump_17.06.0 Aug 2, 2017
@andrewhsu
Copy link
Contributor

Before the revert, saw this error on builds:

[DockerDaemonSuite] FAIL: docker_cli_network_unix_test.go:1677: DockerDaemonSuite.TestDaemonRestartRestoreBridgeNetwork
[DockerDaemonSuite] 
[DockerDaemonSuite] [d4c2f01bc0001] waiting for daemon to start
[DockerDaemonSuite] [d4c2f01bc0001] daemon started
[DockerDaemonSuite] 
[DockerDaemonSuite] [d4c2f01bc0001] waiting for daemon to start
[DockerDaemonSuite] [d4c2f01bc0001] daemon started
[DockerDaemonSuite] 
[DockerDaemonSuite] docker_cli_network_unix_test.go:1733:
[DockerDaemonSuite]     t.Fatal(err)
[DockerDaemonSuite] ... Error: exit status 125
[DockerDaemonSuite] 
[DockerDaemonSuite] [d4c2f01bc0001] exiting daemon

@fcrisciani fcrisciani deleted the revert-1875-restore_17.06 branch August 2, 2017 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants