Skip to content

Conversation

@fcrisciani
Copy link

Fix marshalling and add test

Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com

Fix marshalling and add test

Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@2154459). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1968   +/-   ##
========================================
  Coverage          ?   38.5%           
========================================
  Files             ?     137           
  Lines             ?   27351           
  Branches          ?       0           
========================================
  Hits              ?   10531           
  Misses            ?   15523           
  Partials          ?    1297
Impacted Files Coverage Δ
drivers/overlay/peerdb.go 8.45% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2154459...c32647e. Read the comment docs.

@mavenugo
Copy link
Contributor

mavenugo commented Oct 4, 2017

Thanks for taking care of it @fcrisciani . LGTM

@mavenugo
Copy link
Contributor

mavenugo commented Oct 4, 2017

I will spend some time on this offline to see why the unmarshalling didnt work with IPMask string formating,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants