Skip to content

Conversation

@andrewhsu
Copy link
Contributor

Reverts #1965

From discussion with @fcrisciani, needs more work. Better to revert for now so we can vndr the bump_17.06 branch with changes from @abhi.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "revert-1965-backport-17.06" git@github.com:andrewhsu/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu
Copy link
Contributor Author

cc @mavenugo

@mavenugo
Copy link
Contributor

mavenugo commented Oct 4, 2017

@andrewhsu reverting this will affect #1969. Are you sure about it ? cc @fcrisciani

@fcrisciani
Copy link

fcrisciani commented Oct 4, 2017

This fix is taking care of the failure that I was seeing yesterday. #1969
Not sure about the timing here, today I did not have time to do any further testing on it

@andrewhsu andrewhsu changed the title Revert "[Backport 17.06] Overlay fix for transient IP reuse" [WIP] DO NOT MERGE YET Revert "[Backport 17.06] Overlay fix for transient IP reuse" Oct 4, 2017
@mavenugo
Copy link
Contributor

mavenugo commented Oct 5, 2017

@fcrisciani since #1969 is opened against the bump_17.06 branch and it is dependent on #1965... reverting #1965 will make #1969 useless.

So am not sure what is the purpose of this PR, when #1969 was opened to address the issue ?
cc @andrewhsu do you know ?

@andrewhsu
Copy link
Contributor Author

this is not needed anymore because we got #1969

@andrewhsu andrewhsu closed this Oct 5, 2017
@andrewhsu andrewhsu deleted the revert-1965-backport-17.06 branch October 5, 2017 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants