Skip to content

Conversation

@thaJeztah
Copy link
Member

fixes docker/for-linux#89

thanks @alainvanhoof for reporting

ping @abhi PTAL

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@abhi
Copy link
Contributor

abhi commented Oct 7, 2017

LGTM :)

@codecov-io
Copy link

Codecov Report

Merging #1973 into master will decrease coverage by 0.51%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1973      +/-   ##
==========================================
- Coverage    38.5%   37.98%   -0.52%     
==========================================
  Files         137      137              
  Lines       27351    27351              
==========================================
- Hits        10531    10389     -142     
- Misses      15523    15690     +167     
+ Partials     1297     1272      -25
Impacted Files Coverage Δ
drivers/overlay/ov_network.go 0.26% <0%> (ø) ⬆️
networkdb/networkdb.pb.go 37.31% <0%> (-5.17%) ⬇️
networkdb/delegate.go 70.07% <0%> (-4.61%) ⬇️
endpoint_cnt.go 83.47% <0%> (-2.61%) ⬇️
cmd/proxy/tcp_proxy.go 80.76% <0%> (-1.93%) ⬇️
networkdb/cluster.go 46.3% <0%> (-1.6%) ⬇️
iptables/iptables.go 53.71% <0%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 930c292...e7050e9. Read the comment docs.

Copy link

@fcrisciani fcrisciani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in ErrorLog components/engine/vendor/github.com/docker/libnetwork/drivers/overlay/ov_network.go

4 participants