Handle cleanup DNS for attachable container #1985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attachable containers they are tasks with no service associated their cleanup was not done properly so it was possible to have a leak of their name resolution if that was the last container on the network. Cleanupservicebindings was not able to do the cleanup because there is no service, while also the notification of the delete arrives after that the network is already being cleaned Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
|
there are no tests attached to this PR. |
fcrisciani
pushed a commit
to fcrisciani/libnetwork
that referenced
this pull request
Oct 19, 2017
Unit test for the cleanupServiceDiscovery, follow up of PR: moby#1985 Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
Author
|
@mghazizadeh added test in the #1991 PR |
pradipd
pushed a commit
to pradipd/libnetwork
that referenced
this pull request
Nov 4, 2017
Unit test for the cleanupServiceDiscovery, follow up of PR: moby#1985 Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
This was referenced Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attachable containers they are tasks with no service associated
their cleanup was not done properly so it was possible to have
a leak of their name resolution if that was the last container
on the network.
Cleanupservicebindings was not able to do the cleanup because there
is no service, while also the notification of the delete arrives
after that the network is already being cleaned
Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com