enable unit test in arm64 #2042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arm64 for multi-arch image issue Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
vdemeester
approved these changes
Dec 21, 2017
Member
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🐸
We should probably try to update to go 1.9.x too at some point 👼
Codecov Report
@@ Coverage Diff @@
## master #2042 +/- ##
=========================================
Coverage ? 40.05%
=========================================
Files ? 137
Lines ? 21973
Branches ? 0
=========================================
Hits ? 8801
Misses ? 11863
Partials ? 1309Continue to review full report at Codecov.
|
|
LGTM |
selansen
pushed a commit
to selansen/libnetwork
that referenced
this pull request
Dec 28, 2017
enable unit test in arm64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change base image tag from 1.8.4 to 1.8.5 to enable unit test in arm64 as golang:1.8.4 does not support arm64v8 . help me check @calavera @vdemeester @tomdee @erikh
Signed-off-by: Jianyong Wu jianyong.wu@arm.com