Use new plugin interfaces provided by plugin pkg #2174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CircleCI Failed github.com/docker/libnetwork/vendor/github.com/docker/docker/pkg/parsers/kernelvendor/github.com/docker/docker/pkg/parsers/kernel/kernel_unix.go:21:28: cannot convert uts.Release[:bytes.IndexByte(uts.Release[:], 0)] (type []int8) to type string |
cpuguy83
force-pushed
the
use_plugin_addr
branch
6 times, most recently
from
d26bdce to
8d30437
Compare
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Most of the libcontainer imports was just for a single test to marshal a simple type, meanwhile this caused all kinds of transient imports that are not really needed. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
The use of `Client()` on v2 plugins is being deprecated so that we can be more flexible on the protocol used for plugins. This means checking specifically if the plugin implements the `Client() *plugins.Client` interface for V1 plugins, and for v2 plugins building a the client manually. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
|
@selansen can you carry this one over? |
Contributor
|
Sure. I will take care of this.
…On Mon, Jun 18, 2018 at 2:24 PM, Flavio Crisciani ***@***.***> wrote:
@selansen <https://github.com/selansen> can you carry this one over?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2174 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKEKn4g-tvoy2F6_Gq4ALgEsV628aJ7tks5t9_BlgaJpZM4UVYGZ>
.
|
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
use_plugin_addr
branch
from
8d30437 to
8856c1e
Compare
Member
Author
|
This was replaced by #2199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
Client()on v2 plugins is being deprecated so that we can be more flexible on the protocol used for plugins.This means checking specifically if the plugin implements the
Client() *plugins.Clientinterface for V1 plugins, and for v2 plugins building a the client manually.