[18.03] Migration from CircleCI1.0 to CircleCI2.0 #2207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will allow us to use newer version of CircleCI. Signed-off-by: selansen <elango.siva@docker.com> (cherry picked from commit 2df9b0a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
- cleaned the make check - local build do not require context Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com> (cherry picked from commit 27aa67c) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Thanks @thaJeztah |
Contributor
|
@fcrisciani brought back .dockerginore file back to libnetwork in another PR. we may need to back port it . |
Member
Author
|
Ah, yes; my main concern was making sure that CI would continue to work on the release branch, but if you have time to do a cherry pick 👍 |
Contributor
|
CI will work without Flavio's commit. but we are doing lot of cleanup. I will do it tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #2168 to the bump_18.03 branch
ping @fcrisciani @selansen PTAL