Dockerfile: Install a fixed version of gogoprotobuf #2242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids build failures when gogoprotobuf is changed upstream. Signed-off-by: Euan Harris <euan.harris@docker.com>
Contributor
Author
|
It looks like they have just made a release, so we should consider jumping to v1.1.1 and regenerating in another pull request. Unfortunately this will be more work than just bumping the tag, as we get build failures with the newest version: |
Contributor
Author
|
o fix the undefined message you have to bump the version of protobuf in the vendor from 1.0.0 to 1.1.1 The next problem looks like that the structure PortConfig is not anymore a valid key for a map: |
Contributor
Author
|
@fcrisciani Yes, I don't want to get up to the latest version in this PR - this is just to pin the version of the tools we use so that @selansen can get #2241 to build. Without this change, any PR to master will now fail in the |
sir-xw
pushed a commit
to openkylin/docker.io
that referenced
this pull request
Apr 22, 2025
This results in a XXX_unrecognized of type []byte to be created in the struct. As a side effect the struct can't be used as a map key anymore, resulting in a libnetwork build failure. Fix this by setting goproto_unrecognized_all=false which suppresses this field. Upstream doesn't have the problem because they have pinned an older version of gogo/protobuf: moby/libnetwork#2242 Author: Felix Geyer <fgeyer@debian.org> Gbp-Pq: Name libnetwork_proto_no_unrecognized_all.patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gogoprotobuf has changed upstream and now generates different output. Check out a specific commit to avoid this.
We may be able to do something like this with
go getin 1.11 with 'module aware mode':