controller.loadIPAMDriver: Unwrap error type returned by PluginGetter #2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
Author
moby/moby commit b27f70d45 wraps the ErrNotFound error returned when a plugin cannot be found, to include a backtrace. This changes the type of the error, so contoller.loadIPAMDriver no longer converts it to a libnetwork plugin.NotFoundError. This is a similar patch as was merged in aacec8e Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix_loadIPAMDriver_error_handling
branch
from
e4ff9e2 to
a05dc83
Compare
euanh
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitting this of #2118, but a similar change was already merged in #2183, which had a nice description so I blatantly copied that 😂
moby/moby commit moby/moby@b27f70d45 (moby/moby#36119) wraps the ErrNotFound error returned when
a plugin cannot be found, to include a backtrace. This changes the type of the error, so contoller.loadIPAMDriver no longer converts it to a
ibnetwork plugin.NotFoundError.
This is a similar patch as was merged in aacec8e (#2183)