[19.03] Macvlan: Separate empty parent and internal #2534
Conversation
#2419 and #2407 attempted to seperate out empty parent and internal for macvlan and ipvlan networks However it didnt pass the integration tests in moby moby/moby#40596 and exposed some more plumbing that needed to be done to make sure we separate the two things If the -o parent is empty we create a dummylink and if internal is set we dont add a default gateway and make sure north-south communication cannot take place (only east-west / container-container can) Signed-off-by: Arko Dasgupta <arko.dasgupta@docker.com>
|
Cherry picking this over as I think it's needed to make tests pass on the moby/19.03 branch in moby/moby#40617 |
|
Commenting to indicate for the record that this is a backport of #2523 |
|
@SamWhited I don't think we want to add these changes to 19.03 the above fixes should be available in 20.03/20.04 which is soon :) |
|
Someone had mentioned they thought this is what was causing some of the test failures we were seeing, but I didn't look into it too far. I've been bouncing back and forth between two issues today, so let me see if I can confirm or deny that and get back to you. |
|
Ah my mistake, I mixed up the commits again too. Also, the test failures I was thinking of seem to have magically been fixed and I have no idea why so :nothingtodohere:. |
|
ah so we don't need anything else in |
|
That PR appears to be up to date with the latest commit from bump_19.03 |
3 participants
#2419 and
#2407
attempted to seperate out empty parent and internal for
macvlan and ipvlan networks
However it didnt pass the integration tests in moby
moby/moby#40596 and exposed some
more plumbing that needed to be done to make sure
we separate the two things
If the -o parent is empty we create a dummylink
and if internal is set we dont add a default gateway
and make sure north-south communication cannot take place
(only east-west / container-container can)
Signed-off-by: Arko Dasgupta arko.dasgupta@docker.com