Skip to content

Conversation

@thaJeztah
Copy link
Member

backport of #2544
addresses moby/moby#37506

This PR carryforwards #2239
and incorporates the suggestions in comments to fix the NPE and
potential NPEs due to a null value returned by ep.Iface()

This PR carryforwards moby#2239
and incorporates the suggestions in comments to fix the NPE and
potential NPEs due to a null value returned by ep.Iface()

Signed-off-by: Arko Dasgupta <arko.dasgupta@docker.com>
(cherry picked from commit c55657f)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

@arkodg @cpuguy83 @euanh ptal

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkodg arkodg merged commit b9bcf0c into moby:bump_19.03 Apr 6, 2020
@thaJeztah thaJeztah deleted the 19.03_backport_fix_npe_ep_iface branch April 10, 2020 18:20
thaJeztah added a commit to thaJeztah/docker that referenced this pull request Apr 10, 2020
full diff: moby/libnetwork@0941c3f...b9bcf0c

- moby/libnetwork#2545 Fix NPE due to null value returned by ep.Iface()
    - backport of moby/libnetwork#2544
    - addresses moby#37506

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins pushed a commit to docker-archive/docker-ce that referenced this pull request Apr 30, 2020
full diff: moby/libnetwork@0941c3f...b9bcf0c

- moby/libnetwork#2545 Fix NPE due to null value returned by ep.Iface()
    - backport of moby/libnetwork#2544
    - addresses moby/moby#37506

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Upstream-commit: a6beb24dc5aec6d5919f40728720bd9c61259b15
Component: engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants