Conversation
|
This is currently slightly outdated but I can fix it up if the general direction is fine. Looking for initial feedback. |
|
@eyakubovich Apologies on the delay. Overall approach LGTM. There has been a few changes in the data-structures recently and more coming via #429. But, we can get this merged if you can rebase to the latest and appropriate tests. |
|
I will give rebase shortly. |
|
@eyakubovich Was wondering whether these new files should go inside a separate client package. At the end this is a libnetwork rest client implementation, I feel it should not reside along with the server api files. |
|
@aboch I can put it into a separate package. I was going off that the |
|
Thanks @eyakubovich, net/http is a good reference for this. |
8d7d800 to
178e673
Compare
* Add an implemenation of Controller and related interfaces that makes REST calls to the API endpoint. * Add a new API endpoint to get endpoint info Signed-off-by: Eugene Yakubovich <eugene.yakubovich@coreos.com>
178e673 to
5a71a03
Compare
|
There are some methods that return |
|
Thanks @eyakubovich, I think it makes sense to complete the client api. |
|
@eyakubovich It has been detected that this issue has not received any activity in over 6 months. Can you please let us know if it is still relevant:
Thank you! |
interfaces that makes REST calls to the API endpoint.
Signed-off-by: Eugene Yakubovich eugene.yakubovich@coreos.com