Libnetwork initial refactor for container network model#40
Merged
mavenugo merged 2 commits intomoby:masterfrom Apr 13, 2015
mrjana:cnm
Merged
Libnetwork initial refactor for container network model#40mavenugo merged 2 commits intomoby:masterfrom mrjana:cnm
mavenugo merged 2 commits intomoby:masterfrom
mrjana:cnm
Conversation
driverapi/driverapi.go
Outdated
Contributor
There was a problem hiding this comment.
I understand that the config interface{} is a carry forward from the existing driver code.
This is a bridge between what is available today and where we are going towards.
In order to make this bridge clear, can you please add a clear comment in the code specifying the fact that
this config interface{} will be replaced with generic labels once the configs are properly moved out as a Global Config parameters for the Plugin.
mrjana
changed the title
- Added controller, network, endpoint and sandbox interfaces
- Created netutils package for miscallaneous network utilities
- Created driverapi package to break cyclic dependency b/w driver and libnetwork
- Made libnetwork multithread safe
- Made bridge driver multithread safe
- Fixed README.md
Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jana Radhakrishnan mrjana@docker.com