Fix panic in hijack #34275
Merged
Fix panic in hijack #34275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tibor Vass <tibor@docker.com>
Contributor
|
LGTM |
dnephin
reviewed
Jul 27, 2017
Member
dnephin
left a comment
dnephin
left a comment
There was a problem hiding this comment.
It's strange the docs (https://golang.org/pkg/net/http/httputil/#pkg-variables) suggest ErrPersistEOF is deprecated and not used, even though other docs on that same page still reference it.
Member
|
Should we open an issue for that? |
|
If the panic is in the CLI, don't we need a fix there? |
Member
|
yes;
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tibor Vass tibor@docker.com
Related to docker/cli#380 (needs vendoring in cli)