Address expected vs actual in integration tests

[yongtang]

This fix addresses expected vs actual in integration tests
so that they match assert.Equal(t, expected, actual)

Signed-off-by: Yong Tang yong.tang.github@outlook.com

[dnephin]

LGTM

Although I think testify is wrong here. It should be (actual, expected) to be consistent with other asserts.

This is fixed in gotestyourself/assert by allowing either, and using the variable names to report which value is expected.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@4b2fb7e). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #36490   +/-   ##
=========================================
  Coverage          ?   34.66%           
=========================================
  Files             ?      613           
  Lines             ?    45387           
  Branches          ?        0           
=========================================
  Hits              ?    15733           
  Misses            ?    27595           
  Partials          ?     2059

[yongtang]

Rebased to resolve merge conflicts.

[thaJeztah]

experimental failed on https://jenkins.dockerproject.org/job/Docker-PRs-experimental/39638/console; restarting

21:27:49 ----------------------------------------------------------------------
21:27:49 FAIL: docker_cli_push_test.go:206: DockerSchema1RegistrySuite.TestConcurrentPush
21:27:49 
21:27:49 docker_cli_push_test.go:207:
21:27:49     testConcurrentPush(c)
21:27:49 docker_cli_push_test.go:186:
21:27:49     c.Assert(err, checker.IsNil, check.Commentf("concurrent push failed with error: %v", err))
21:27:49 ... value *exec.ExitError = &exec.ExitError{ProcessState:(*os.ProcessState)(0xc4205d8000), Stderr:[]uint8(nil)} ("exit status 1")
21:27:49 ... concurrent push failed with error: exit status 1
21:27:49 
21:27:50